Fix uncaught type error on clicking lexical this #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryu39
changed the title
ryu39
force-pushed
the
fix/uncaught_type_error_on_clicking_lexical_this
branch
from
524a2a5
to
fdaf2b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for nice documents about ES6 features.
I found a slight issue on clicking 'Lexical this' in side menu, please see the following image.
When 'Lexical this' link is clicked, the
ev.targetdoes not contain<a>tag element, but<code>tag element under<a>tag. And<code>tag does not havehrefattribute, so error is occurred.I fixed this issue by using
$(this)instead of$(ev.target). Also the argumentevis not used, so I removed it.