support recording canvas in iframe and shadow dom #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: db60778 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Mar 18, 2024
# Conflicts: # packages/rrweb/src/record/observers/canvas/canvas-manager.ts
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
May 29, 2024
Resolves getsentry/sentry-javascript#10758 rrweb PR: rrweb-io#1428 <details> <summary> Before </summary> <p> Red square is on the main page;<br> Green is inside the shadow dom on the main page;<br> Blue one is within the iframe;<br> Pink is inside the shadow dom within the iframe. </p> <video src="https://github.com/rrweb-io/rrweb/assets/25964451/110f1e36-0a74-4d1c-9cd7-d28eba95af05"/> </details> <details> <summary> After </summary> <video src="https://github.com/rrweb-io/rrweb/assets/25964451/902495b5-e1b3-40d0-85af-6aeff58a5628"/> </details>
|
It still working? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1412, resolves #1081
Before
Red square is on the main page;
Green is inside the shadow dom on the main page;
Blue one is within the iframe;
Pink is inside the shadow dom within the iframe.
canvas-iframe-before.mov
After
canvas-iframe-after.mov
Key differences from existing PRs:
sampling: 'all'modeShadowDomManageris utilized for obtaining information about the shadow DOMs, rather than looping through all the elements on the pagetakeCanvasSnapshotsloop on reset