Restore cffi mode message when running install. #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
reviewed
Jul 4, 2020
setup.py
Outdated
| @@ -22,6 +22,7 @@ | |||
|
|
|||
| from setuptools import setup | |||
| from distutils.command.build import build as du_build | |||
| from distutils.command.install import install as du_install | |||
There was a problem hiding this comment.
You may want to use setuptools.command.install here...
Codecov Report
@@ Coverage Diff @@
## master #718 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 39 39
Lines 6420 6420
=======================================
Hits 5757 5757
Misses 663 663 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to PR #716