Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print where and when cr_hascontrollchars is true #425

Merged
merged 1 commit into from Mar 4, 2024

Conversation

sergiomb2
Copy link
Contributor

@sergiomb2 sergiomb2 commented Mar 2, 2024

Relates to issue #424.

tested with packages https://download.copr.fedorainfracloud.org/archive/issues/copr-3163/ , as referenced
fedora-copr/copr#3163

now I got (as expected) these lines [1] the problem on nodejs-electron.spec was here [2]

[1]
createrepo_c .

Directory walk started
Directory walk done - 5 packages
Temporary output repo path: ./.repodata/
Pool started (with 5 workers)
Package RPM license AFL-2.0 AND Apache-2.0 AND blessing AND BSD-2-Clause AND BSD-3-Clause AND BSD-Protection AND BSD-Source-Code AND bzip2-1.0.6 AND IJG AND ISC AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND MIT AND MIT-CMU AND MIT-open-group AND (MPL-1.1 OR GPL-2.0-or-later OR LGPL-2.1-or-later) AND MPL-2.0 AND OpenSSL AND SGI-B-2.0 AND SUSE-Public-Domain AND X11 AND Zlib contains forbidden control chars (ASCII values <32 except 9, 10 and 13).
C_CREATEREPOLIB: Critical: Cannot dump XML for nodejs-electron-devel (b5373d44fd0b922cf7b43bb27ad39b9c0878ce44edb12959b9915b1849a8e0f3): Forbidden control chars found (ASCII values <32 except 9, 10 and 13).
Package RPM license AFL-2.0 AND Apache-2.0 AND blessing AND BSD-2-Clause AND BSD-3-Clause AND BSD-Protection AND BSD-Source-Code AND bzip2-1.0.6 AND IJG AND ISC AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND MIT AND MIT-CMU AND MIT-open-group AND (MPL-1.1 OR GPL-2.0-or-later OR LGPL-2.1-or-later) AND MPL-2.0 AND OpenSSL AND SGI-B-2.0 AND SUSE-Public-Domain AND X11 AND Zlib contains forbidden control chars (ASCII values <32 except 9, 10 and 13).
C_CREATEREPOLIB: Critical: Cannot dump XML for nodejs-electron-doc (6551f31fd59ced0f6832fefce64a94deb9230dae3b74a871311e1b1d71a4a635): Forbidden control chars found (ASCII values <32 except 9, 10 and 13).
Package RPM license AFL-2.0 AND Apache-2.0 AND blessing AND BSD-2-Clause AND BSD-3-Clause AND BSD-Protection AND BSD-Source-Code AND bzip2-1.0.6 AND IJG AND ISC AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND MIT AND MIT-CMU AND MIT-open-group AND (MPL-1.1 OR GPL-2.0-or-later OR LGPL-2.1-or-later) AND MPL-2.0 AND OpenSSL AND SGI-B-2.0 AND SUSE-Public-Domain AND X11 AND Zlib contains forbidden control chars (ASCII values <32 except 9, 10 and 13).
C_CREATEREPOLIB: Critical: Cannot dump XML for nodejs-electron (6cf2159a44f86310c430292ceaa231a71f07eda8590f2507ab884771d0f5ade8): Forbidden control chars found (ASCII values <32 except 9, 10 and 13).
Package RPM license AFL-2.0 AND Apache-2.0 AND blessing AND BSD-2-Clause AND BSD-3-Clause AND BSD-Protection AND BSD-Source-Code AND bzip2-1.0.6 AND IJG AND ISC AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND MIT AND MIT-CMU AND MIT-open-group AND (MPL-1.1 OR GPL-2.0-or-later OR LGPL-2.1-or-later) AND MPL-2.0 AND OpenSSL AND SGI-B-2.0 AND SUSE-Public-Domain AND X11 AND Zlib contains forbidden control chars (ASCII values <32 except 9, 10 and 13).
C_CREATEREPOLIB: Critical: Cannot dump XML for nodejs-electron (9584d3fed1bde5062f19bbedb20081cbe96dc7f10f92e0c22821d9a1e2969af0): Forbidden control chars found (ASCII values <32 except 9, 10 and 13).
Pool finished with errors
Warning: There were some invalid packages: we have to recompress other, filelists and primary xml metadata files in order to have correct package counts

[2]

%define AndZlib %{quote: AND Zlib}
License:        AFL-2.0 AND Apache-2.0 AND blessing AND BSD-2-Clause AND BSD-3-Clause AND BSD-Protection AND BSD-Source-Code AND bzip2-1.0.6 AND IJG AND ISC AND LGPL-2.0-or-later AND LGPL-2.1-or-later AND MIT AND MIT-CMU AND MIT-open-group AND (MPL-1.1 OR GPL-2.0-or-later OR LGPL-2.1-or-later) AND MPL-2.0 AND OpenSSL AND SGI-B-2.0 AND SUSE-Public-Domain AND X11%{AndZlib}

@ppisar ppisar self-assigned this Mar 4, 2024
@ppisar ppisar added Triaged Someone on the DNF team has read the issue and determined the next steps to take Priority: LOW labels Mar 4, 2024
@ppisar
Copy link
Contributor

ppisar commented Mar 4, 2024

This is a very minimal fix. My idea was reporting an exact offset in the strings, and reporting it up instead of printing it directly. I do not want to burden you with my maximal idea.

I will accept this patch, but please change the commit message so it's phrased as an "partial fix". I'd like to keep the issue open and supplement it with a proper fix later.

@sergiomb2
Copy link
Contributor Author

sure, let me know if it is all right now.

@ppisar ppisar merged commit dd234a8 into rpm-software-management:master Mar 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: LOW Triaged Someone on the DNF team has read the issue and determined the next steps to take
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants