Make some ciphers optional #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
cipher-features
branch
from
43d78e1
to
79a3253
Compare
|
any particular reason for this change? |
|
I want to remove support for DES and Cast5 and blowfish from Delta Chat. Maybe also twofish. These packages add unnecessary dependencies and 3DES is insecure. |
|
One thing if you don't mind... Why not leave enum unchanged even if the algo is not supported and only return "unsupported" errors when trying to use the algo that has been unselected? This way the errors could be more descriptive (like unsupported algorithm cast5) instead of errors during parsing (unsupported algorithm constant 5). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.