Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powers, Roots, and more #131

Open
wants to merge 12 commits into
base: Rel/2024-04-m1
Choose a base branch
from

Conversation

Jsoto22
Copy link
Collaborator

@Jsoto22 Jsoto22 commented Apr 3, 2024

This update allows for fractional exponents to be used in the pow method. It also adds public methods for square/cube roots, exponentiation of Euler's constant, Euler's constant as a static property, and factorials.

- Allows for any size Integer to be used as an exponent
Adds 'Euclidean division' Modulus operation and simplifies Modulus Remainder sign logic. Unit tests added.
Implements support for fractional exponents in powers and integer only roots
Adds new features and updates REAMDME.md
Todo: expand unit testing for new features.
@Jsoto22
Copy link
Collaborator Author

Jsoto22 commented Apr 3, 2024

@royNiladri Hope I'm not too late on this but had to work out some precision issues. They're mostly resolved, but I plan to maybe add user defined limits on the public facing method for pow. I'll try to wrap this up by finishing the unit testing tonight, then it should be ready for review.

- Fixed typing issues in BigDecimal validate
- Removed deprecated substr functions
- Added wrapper logic functions to compareTo
- Fully implemented 'UNNECESSARY' rounding mode
@Jsoto22
Copy link
Collaborator Author

Jsoto22 commented Apr 5, 2024

@royNiladri latest commit implements "UNNECESSARY" rounding mode into roundOff method

Added unit test for roots. Should close #126

Looked into #22 and have a basic plan to implement Locale Aware numbering systems. I'll open a new branch for that after the next release.

@Jsoto22 Jsoto22 marked this pull request as ready for review April 5, 2024 20:59
@royNiladri
Copy link
Owner

Hi @Jsoto22 You have some conflicts on this PR. I have added you as a contributor to the repository.. So you can start working on the repository directly. Create a separate branch, and merge all changes from the release branch.

@Jsoto22
Copy link
Collaborator Author

Jsoto22 commented Apr 6, 2024

@royNiladri I fixed the conflicts directly. I had left them so you could be aware of what would change in those files. This pr should be good to go now.

@Jsoto22 Jsoto22 mentioned this pull request Apr 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants