More exhaustive testing by property-based testing #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okapies
force-pushed
the
feature/property-testing
branch
16 times, most recently
from
b81819b
to
446777b
Compare
okapies
force-pushed
the
feature/property-testing
branch
from
446777b
to
7cad095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some test cases by using hypothesis, a property-based testing library. I also introduce textdistance as a test oracle and the test cases compare its results with those of it. It is still not enough (because I don't know very well about the details of the Unicode spec like combining characters) but they prove editdistance works for sentences consist of ASCII codes, Hiraganas, and Katakanas in a more precise way.
Note: I noticed that pyxDamerauLevenshtein referred by the benchmark is an implementation of Damerau-Levenshtein distance which supports transposition, unlike original Levenshtein algorithm (e.g. edit distance between "AB" and "BA" is
1instead of2in DL). It seems it is not suitable for comparison.