Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lexer for IEC 61131-3 Structured Text #2027

Merged
merged 1 commit into from May 13, 2024
Merged

Conversation

tali
Copy link
Contributor

@tali tali commented Feb 21, 2024

The new lexer uses sets of keywords to quickly categorize names and uses regular expressions for other elements like numbers and punctuation.

Closes #2024

@tali
Copy link
Contributor Author

tali commented Feb 21, 2024

This is still in draft, I'd still like to work on disambiguation and include better example code.
I already created this PR to be able to obtain some feedback about the current state.
Especially feedback from smalltalk experts would be helpful for disambiguation of *.st files.
Ruby is not my native language, so please also have a closer look that I did everything right.

@tali tali marked this pull request as ready for review March 3, 2024 22:41
@tali tali force-pushed the master branch 2 times, most recently from 1ebfe1f to 99fe27d Compare March 18, 2024 15:42
@tali
Copy link
Contributor Author

tali commented Mar 18, 2024

(just rebased to current master)

@bufferoverflow
Copy link

@tali I really like this addition! I guess this is no longer draft and ready for maintainer review?

@tali
Copy link
Contributor Author

tali commented Apr 15, 2024

This code passes all my tests and is able to highlight our production code. From my side it is ready.
@jneen, @gfx, what do you think? Can we merge it?

@tali
Copy link
Contributor Author

tali commented May 2, 2024

Hi @tancnle, can you have a look please? I'd like to get this into the next release so that we can use it in our company GitLab.

@bufferoverflow
Copy link

@dblessing could you maybe review this? Would be a great addition to GitLab!

@tancnle
Copy link
Collaborator

tancnle commented May 12, 2024

@tali @bufferoverflow I will have a look at it sometime today.

@tancnle tancnle self-assigned this May 12, 2024
@tancnle tancnle added the needs-review The PR needs to be reviewed label May 12, 2024
lib/rouge/lexers/iecst.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/iecst.rb Outdated Show resolved Hide resolved
The new lexer uses sets of keywords to quickly categorize names and uses
regular expressions for other elements like numbers and punctuation.
@tancnle
Copy link
Collaborator

tancnle commented May 13, 2024

Thanks, @tali. LGTM 🚀

@tancnle tancnle added this pull request to the merge queue May 13, 2024
Merged via the queue into rouge-ruby:master with commit 1ab0290 May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for IEC 61131-3 Structured Text
3 participants