Add: tracepoint for subscribe serialized_message #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
lgtm with green CI.
@asorbini i would like to request review.
|
It would be good to rebase this branch on |
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
Signed-off-by: h-suzuki <h-suzuki@isp.co.jp>
h-suzuki-isp
force-pushed
the
add_tracepoint
branch
from
c992fa1
to
b62c201
Compare
@christophebedard OK, I rebased. |
christophebedard
suggested changes
Mar 27, 2024
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: h-suzuki-isp <146712054+h-suzuki-isp@users.noreply.github.com>
Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: h-suzuki-isp <146712054+h-suzuki-isp@users.noreply.github.com>
christophebedard
approved these changes
Mar 28, 2024
fujitatomoya
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, refer to ros2/rclcpp#2448 .
I have added the following trace points.
rmw_api_connextdds_take_serialized_message()rmw_api_connextdds_take_serialized_message_with_info()