-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graph_reasoning to rosdistro #40804
base: master
Are you sure you want to change the base?
Conversation
New package review checklist
|
Hello @clalancette, could you update if the changes made to the repos names are okay? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New package review checklist
- At least one of the following must be present
- Top level license file:
- Per package license files:
- License is OSI-approved: GPLv3
- License correctly listed in package.xmls
- Public source repo: https://github.com/snt-arg/situational_graphs_reasoning
- Source repository contains ROS packages
- Each package meets REP-144 naming conventions
I'm going to approve this, but I suggest that you update https://github.com/snt-arg/situational_graphs_reasoning/blob/develop/setup.py to add in the maintainer and license.
Because of the other PRs we merged in, this needs to be rebased. Once that is done, we can merge this one in. |
…e/add_graph_reasoning
Rebased with master :) |
Package names:
Package Upstream Source:
https://github.com/snt-arg/graph_reasoning.git
Purpose of using this:
Reasoning on the low-level graph (i.e planes) generated by lidar_s_graphs for the automatic generation of high-level entities likes rooms, walls etc.
PR related to
lidar_s_graphs
---> #40800Please Add This Package to be indexed in the rosdistro.
Iron and Humble
The source is here:
https://github.com/snt-arg/graph_reasoning.git
Checks