Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graph_reasoning to rosdistro #40804

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hridaybavle
Copy link
Contributor

Package names:

Package Upstream Source:

https://github.com/snt-arg/graph_reasoning.git

Purpose of using this:

Reasoning on the low-level graph (i.e planes) generated by lidar_s_graphs for the automatic generation of high-level entities likes rooms, walls etc.

PR related to lidar_s_graphs ---> #40800

Please Add This Package to be indexed in the rosdistro.

Iron and Humble

The source is here:

https://github.com/snt-arg/graph_reasoning.git

Checks

  • [ x] All packages have a declared license in the package.xml
  • [ x] This repository has a LICENSE file
  • [ x] This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added humble Issue/PR is for the ROS 2 Humble distribution iron Issue/PR is for the ROS 2 Iron distribution labels Apr 24, 2024
@clalancette
Copy link
Contributor

New package review checklist

  • At least one of the following must be present
    • Top level license file:
    • Per package license files:
  • License is OSI-approved: GPLv3
  • License correctly listed in package.xmls
  • Public source repo: https://github.com/snt-arg/graph_reasoning
  • Source repository contains ROS packages
  • Each package meets REP-144 naming conventions - Unfortunately the name is very generic, and doesn't really tell us what it does. I'm going to suggest you rename this to situational_graph_reasoning or snt_situational_graph_reasoning, which will explain what it does a lot better.

@hridaybavle
Copy link
Contributor Author

Hello @clalancette, could you update if the changes made to the repos names are okay?

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New package review checklist

I'm going to approve this, but I suggest that you update https://github.com/snt-arg/situational_graphs_reasoning/blob/develop/setup.py to add in the maintainer and license.

@clalancette
Copy link
Contributor

Because of the other PRs we merged in, this needs to be rebased. Once that is done, we can merge this one in.

@hridaybavle
Copy link
Contributor Author

Rebased with master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution iron Issue/PR is for the ROS 2 Iron distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants