-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graph_datasets to rosdistro #40803
base: master
Are you sure you want to change the base?
Conversation
New package review checklist
Besides that, the source repository is missing a |
Hello @clalancette, I have done the renaming of the repos as suggested by you previously. They now start with a prefix Also this source repo now has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New package review checklist
- At least one of the following must be present
- Top level license file:
- Per package license files:
- License is OSI-approved: GPLv3
- License correctly listed in package.xmls
- Public source repo: https://github.com/snt-arg/situational_graphs_datasets
- Source repository contains ROS packages
- Each package meets REP-144 naming conventions
I'm going to approve this, but I will suggest that you update https://github.com/snt-arg/situational_graphs_datasets/blob/develop/setup.py to include the license and the maintainer.
Note that this needs to be rebased now because we merged some of the other packages. Once that is done, we can get this in, thanks! |
…e/add_graph_datasets
Rebased with master :) |
Package names:
Package Upstream Source:
https://github.com/snt-arg/graph_datasets.git
Purpose of using this:
Structured indoors synthetic dataset in the form of graphs as a tool for lidar_s_graphs.
PR related to
lidar_s_graphs
---> #40800Please Add This Package to be indexed in the rosdistro.
Iron and Humble
The source is here:
https://github.com/snt-arg/graph_datasets.git
Checks