Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reasoning_msgs to rosdistro #40802

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hridaybavle
Copy link
Contributor

Package names:

Package Upstream Source:

https://github.com/snt-arg/reasoning_msgs.git

Purpose of using this:

Repository to contains custom ros2 msgs for lidar_s_graphs, required for exchanging high-level reasoning information to and from the lidar_s_graphs node.

PR related to lidar_s_graphs ---> #40800

Please Add This Package to be indexed in the rosdistro.

Iron and Humble

The source is here:

https://github.com/snt-arg/reasoning_msgs.git

Checks

  • [ x] All packages have a declared license in the package.xml
  • [ x] This repository has a LICENSE file
  • [ x] This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added humble Issue/PR is for the ROS 2 Humble distribution iron Issue/PR is for the ROS 2 Iron distribution labels Apr 24, 2024
@@ -6375,6 +6375,12 @@ repositories:
url: https://github.com/ros/resource_retriever.git
version: humble
status: maintained
reasoning_msgs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem here is that "reasoning" is too generic a term. I'm going to suggest we rename this to situational_graph_reasoning_msgs, which will make this a lot easier to understand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette this will require some changes at the code level also, I will do it and come back with a new commit.

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label May 14, 2024
@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label May 15, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New package review checklist

@clalancette
Copy link
Contributor

I approve of this, but this now has conflicts because we merged in the other PR. If you can rebase this to resolve the conflicts, we can go ahead and merge. Thanks!

@hridaybavle
Copy link
Contributor Author

Rebased with master :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution iron Issue/PR is for the ROS 2 Iron distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants