-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reasoning_msgs to rosdistro #40802
base: master
Are you sure you want to change the base?
Conversation
humble/distribution.yaml
Outdated
@@ -6375,6 +6375,12 @@ repositories: | |||
url: https://github.com/ros/resource_retriever.git | |||
version: humble | |||
status: maintained | |||
reasoning_msgs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem here is that "reasoning" is too generic a term. I'm going to suggest we rename this to situational_graph_reasoning_msgs
, which will make this a lot easier to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clalancette this will require some changes at the code level also, I will do it and come back with a new commit.
This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New package review checklist
- At least one of the following must be present
- Top level license file:
- Per package license files:
- License is OSI-approved: GPLv3
- License correctly listed in package.xmls
- Public source repo: https://github.com/snt-arg/situational_graphs_reasoning_msgs
- Source repository contains ROS packages
- Each package meets REP-144 naming conventions
I approve of this, but this now has conflicts because we merged in the other PR. If you can rebase this to resolve the conflicts, we can go ahead and merge. Thanks! |
…e/add_reasoning_msgs
Rebased with master :) |
Package names:
Package Upstream Source:
https://github.com/snt-arg/reasoning_msgs.git
Purpose of using this:
Repository to contains custom ros2 msgs for lidar_s_graphs, required for exchanging high-level reasoning information to and from the
lidar_s_graphs
node.PR related to
lidar_s_graphs
---> #40800Please Add This Package to be indexed in the rosdistro.
Iron and Humble
The source is here:
https://github.com/snt-arg/reasoning_msgs.git
Checks