Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REP-144 check list to pr template, and split pull request template files #40518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ijnek
Copy link
Contributor

@ijnek ijnek commented Apr 9, 2024

  • Adds REP-144 information and updates the DOC INDEX TEMPLATE
  • Since the PR template becomes rather large and readability is reduced, I have also split the pull request templates into mupltiple templates which can be selected from the root pr template.
  • Improvements to language and formatting to increase readability of templates.

Supercedes #39987.

@mjcarroll
Copy link
Member

Is the PULL_REQUEST_TEMPLATE feature new? I believe that we had tried this in the past without success, you had to put it all in a single markdown file

@ijnek
Copy link
Contributor Author

ijnek commented Apr 9, 2024

As far as I can tell, this feature has been available for a few years. One caveat is that GitHub lacks a user-friendly interface for selecting templates, unlike GitHub issue templates (eg. ros2-gbp's issue template selection).

Without a user-friendly interface, to access the other templates, one needs to utilize a query string in the URL (e.g., ?template=rosdep_rule_template.md). To circumvent this lack of interface, the root PR template is designed to include links to the other specialized PR templates.

Here's a screenshot of the root PR:

image

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Apr 24, 2024
@ijnek
Copy link
Contributor Author

ijnek commented Apr 24, 2024

Please remove the 'stale' label, this is waiting for review

@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label Apr 25, 2024
Copy link

github-actions bot commented May 9, 2024

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue/PR hasn't been active in a while and may be closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants