Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ros-noetic-tf installs /opt/ros/noetic/lib/python3/dist-packages/libgtest.so #223

Open
v4hn opened this issue Feb 22, 2021 · 0 comments
Open

ros-noetic-tf installs /opt/ros/noetic/lib/python3/dist-packages/libgtest.so #223

v4hn opened this issue Feb 22, 2021 · 0 comments

Comments

@v4hn
Copy link
Contributor

v4hn commented Feb 22, 2021

This leads to strange package conflicts in released packages (Cross-post of PR2/pr2_mechanism#343).

To the best of my knowledge this library should not exist and most definitely should not be installed by two entirely unrelated packages that make no explicit mention of it.

As the library does not exist in melodic on Ubuntu 18.04, it might be related to a change in python3.
I can see the library in a (non-Ubuntu) melodic workspace built on python3 as well, but cannot easily verify where it came from in that workspace.
roehling added a commit to fkie-forks/catkin that referenced this issue Feb 22, 2021
@roehling
Fix problem with Googletest's LIBRARY_OUTPUT_DIRECTORY
42fb213 
The horribly maintained CMake files which are shipped with Googletest
override the library output directory to ${CMAKE_BINARY_DIR}/lib, which
points to the top-level build directory (it should have been
CMAKE_CURRENT_BINARY_DIR).

Unfortunately, that directory is used by setuptools as staging area for
Python modules, and setup.py install will happily install everything it
finds in the lib/ folder, including the libgtest.so binary. Among
others, this has bitten PR2/pr2_mechanism#343 and ros/geometry#223

This PR fixes the output location to something sane(ish).
@roehling roehling mentioned this issue Feb 22, 2021
Merged
mjcarroll pushed a commit to ros/catkin that referenced this issue Apr 19, 2021
@roehling
Fix problem with Googletest's LIBRARY_OUTPUT_DIRECTORY (#1135)
7fa3eb3 
The horribly maintained CMake files which are shipped with Googletest
override the library output directory to ${CMAKE_BINARY_DIR}/lib, which
points to the top-level build directory (it should have been
CMAKE_CURRENT_BINARY_DIR).

Unfortunately, that directory is used by setuptools as staging area for
Python modules, and setup.py install will happily install everything it
finds in the lib/ folder, including the libgtest.so binary. Among
others, this has bitten PR2/pr2_mechanism#343 and ros/geometry#223

This PR fixes the output location to something sane(ish).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@v4hn