Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative to #641: Checking which layers to clear #1005

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from

Conversation

DLu
Copy link
Member

@DLu DLu commented Jul 3, 2020

  • Tries both "obstacles" and "obstacle_layer" as default parameters.
  • Prints the actual layers that it will clear, as opposed to the value of the parameter.
  • Prints an error if no layers will be cleared.

CC: @LeroyR

@LeroyR
Copy link

LeroyR commented Jul 6, 2020

👍

You need to update/verify test results.

@SteveMacenski
Copy link
Member

@DLu on this subject I filed a ticket in navigation2: ros-navigation/navigation2#1850 - do you agree with my idea of adding an API method for clearable for the layer itself so that we can remove the parameterization (which cough I've frequently forgotten existed cough)

@DLu
Copy link
Member Author

DLu commented Jul 17, 2020

The problem with adding the clearable() method to the API is that sometimes you may want to specify which recoveries clear which layers. I've seen configurations where you clear different layers in different recoveries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants