Add support for multiple GitHub deploy key mappings with GitHub Actions #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rwarding Add support for multiple GitHub deploy key mappings with GitHub Actions
This was referenced Feb 20, 2023
Comment on lines
+99
to
+100
| ici_forward_mount /home/runner/.gitconfig rw | ||
| ici_forward_mount /home/runner/.ssh rw |
There was a problem hiding this comment.
We cannot hardcode Gihub-specific paths.
|
Please try adding .gitconfig here: And why would we mount them rw? |
|
I think we could just add |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed as a solution to #807
When cloning multiple private GitHub repositories with SSH, you can use the deploy key mapping feature of the webfactory/ssh-agent GitHub action to map specific SSH keys to their respective GitHub repositories. This works as intended when cloning in the main GitHub runner environment, but fails to translate over to the industrial_ci docker environment.
Webfactory/ssh-agent specifically calls this out and suggests to copy the
~/.sshdirectory and~/.gitconfigfile into the docker container to ensure the mappings are carried over. This change simply adds two new docker mount arguments to import the SSH configuration into the Docker container's build environment.