Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Control Azimuthal Window with Driver #117

Open
vinnnyr opened this issue Oct 14, 2022 · 4 comments
Open

[feature request] Control Azimuthal Window with Driver #117

vinnnyr opened this issue Oct 14, 2022 · 4 comments

Comments

@vinnnyr
Copy link
Contributor

vinnnyr commented Oct 14, 2022

It would be nice to be able to control the azimuthal window of the lidar via a parameter file rather than control it using the firmware page
image

@SteveMacenski
Copy link
Member

If there's a parameter in the SDK that lets us control that, we can certainly expose it! I see no qualms with that.

@vinnnyr
Copy link
Contributor Author

vinnnyr commented Oct 14, 2022

after digging I realized someone else proposed this: #98 and the underlying version here: ouster-lidar/ouster_example#366

@bertaveira
Copy link
Contributor

The problem was that after discussing in the main repo it was mentioned that azimuth window change in the lidar config requires a restart of the lidar (not manually but it has to internally restart). Therefore having that as a parameter would make the lidar have to start up twice taking twice as long to start then.

@SteveMacenski
Copy link
Member

I can see their worry, but personally I'd say "OK" to that and just make sure its both documented and when its changed a warning is thrown to let someone know. If startup time is something they care about, then they can make that change more permanently elsewhere to help here - but that way they know but isn't blocking others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants