Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating Fastlane #194

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Deprecating Fastlane #194

wants to merge 15 commits into from

Conversation

LetoFranco
Copy link
Contributor

@LetoFranco LetoFranco commented Feb 15, 2022

Description:

  • Removing Fastlane from code

Motivation

The motivation behind this change is to have a code base from which we can decide and add our decisions in each project on top of the base, without having to double check after using the script to see what we should have and what we should delete.

For example:
I think it's preferable not to have commented decisions in the readme, because it's similar to having commented code.


Alternative 1

Generate an issue in Github to create a notion page to store how to install and integrate Fastlane to a project.

Generate another issue to find a way to store the fastlane configuration file in some project to show how it is integrated.


Alternative 2

Another solution, could be to modify the script to add a check to ask if you want to keep fastlane or bitrise or leave it custom.

In case you decide to go for fastlane, see if it is installed or install it, and if not, remove the fastlane traces.

@glm4
Copy link
Collaborator

glm4 commented Feb 15, 2022

@LetoFranco what's the motivation for this change?
The last think I know is that we want the ios-base to be an example of how to configure our CI/CD workflows with Fastlane.

@LetoFranco
Copy link
Contributor Author

@LetoFranco what's the motivation for this change? The last think I know is that we want the ios-base to be an example of how to configure our CI/CD workflows with Fastlane.

Hey @glm4, i added more details to the description in order to give more visibility about the motivations of the change.

@glm4
Copy link
Collaborator

glm4 commented Feb 15, 2022

@LetoFranco what's the motivation for this change? The last think I know is that we want the ios-base to be an example of how to configure our CI/CD workflows with Fastlane.

Hey @glm4, i added more details to the description in order to give more visibility about the motivations of the change.

I think we should discuss this on the next iOS Roundtable as a team, and take a better look at the possible advantages and disadvantages.

Copy link
Collaborator

@glm4 glm4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LetoFranco Can you make sure all the following works for the repo after removing Fastlane?

The only thing we would need to change is to run the test suite from the Github actions by using xcodebuild ... test rather than the fastlane run_test_suite lane.
If we decide NOT TO go with the Fastlane approach because it introduces complexity to the workflow, the minimum requirements I considere this repository should met are:
The test suite must run for each PR and changes to master
The code coverage report to Code Climate must continue working.

@@ -1,7 +0,0 @@
source 'https://rubygems.org'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LetoFranco why is this file deleted?

@glm4 glm4 changed the base branch from master to main August 16, 2022 19:40
@glm4 glm4 requested a review from fconelli as a code owner August 16, 2022 19:40
@glm4 glm4 requested a review from a user August 16, 2022 19:40
@glm4 glm4 force-pushed the removingFastlane branch 3 times, most recently from 7533686 to 8a0e970 Compare September 1, 2022 19:21
@glm4 glm4 mentioned this pull request Oct 11, 2022
@LetoFranco LetoFranco closed this Jan 27, 2023
@LetoFranco LetoFranco deleted the removingFastlane branch January 27, 2023 19:47
@LetoFranco LetoFranco restored the removingFastlane branch February 13, 2023 23:35
@LetoFranco LetoFranco reopened this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants