Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[upd] wordpress-site.conf.j2 fix deprecated directive nginx ^1.25.1 #1512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arisonadim
Copy link

Fix for nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead

Fix for nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead
@swalkinshaw
Copy link
Member

I'm not sure this should be merged yet since it's just a deprecation warning. It could cause problems if people re-provision servers but don't upgrade Nginx.

1.25.1 was released in June

@arisonadim
Copy link
Author

Thanks for the response,
I've faced problem when provision fresh trellis install. Despite the fact that this is just a warning, provision process has been halted.

Ubuntu 22.04.4 LTS (Jammy Jellyfish)

@swalkinshaw
Copy link
Member

Despite the fact that this is just a warning, provision process has been halted.

Can you post the logs of where this happens? I just tried a brand new provision and it runs successfully without seeing any warnings. I only see them if I run nginx -t:

nginx -t
nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/sites-enabled/example.com.conf:5
nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/sites-enabled/example.com.conf:6
nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/sites-enabled/example.com.conf:127
nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/sites-enabled/example.com.conf:128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants