Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[df] Add function to check if dataframe origin is TTree or TChain #15500

Closed

Conversation

kristupaspranc
Copy link
Contributor

No description provided.

@pcanal
Copy link
Member

pcanal commented May 14, 2024

In which context is this needed/useful?

@kristupaspranc
Copy link
Contributor Author

For RBatchGenerator. @vepadulano will review the code and say if it is needed.
Apologies for not providing the context.

@vepadulano
Copy link
Member

vepadulano commented May 17, 2024

Thank you @kristupaspranc for this addition! Indeed in the RBatchGenerator this information is nice to have. It turns out that a similar approach improves also the code for distributed RDataFrame, I opened a PR #15554 that I believe respects functionally the same goal as this one. In your case you could just check in the batch generator code for if (GetDataSourceLabel(df) == "TTreeDS").

@kristupaspranc
Copy link
Contributor Author

Yes, the functionality is exactly what the RBatchGenerator also needs. The primary idea itself was copied from the inner file of RDataFrame. Closing the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants