Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with CMP0148 #15497

Merged
merged 1 commit into from May 13, 2024
Merged

Comply with CMP0148 #15497

merged 1 commit into from May 13, 2024

Conversation

vepadulano
Copy link
Member

@vepadulano vepadulano self-assigned this May 13, 2024
@vepadulano vepadulano requested a review from bellenot as a code owner May 13, 2024 13:49
vgvassilev
vgvassilev reviewed May 13, 2024
View reviewed changes
Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no expert but lgmt in a first glance. Deferring to @bellenot ;)

guitargeek
guitargeek approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm reviewing this because it's a follow-up to some PR of mine. I just forgot to do the same change for cling.

@github-actions GitHub Actions
Copy link

Test Results

    10 files      10 suites   1d 22h 37m 0s ⏱️
 2 635 tests  2 635 ✅ 0 💤 0 ❌
24 868 runs  24 868 ✅ 0 💤 0 ❌

Results for commit ae4c58e.

@vepadulano vepadulano merged commit 44cff59 into root-project:master May 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev vgvassilev left review comments

@guitargeek guitargeek guitargeek approved these changes

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

Assignees

@vepadulano vepadulano

Labels
in:Cling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vepadulano @vgvassilev @guitargeek