[ntuple] add support for std::optional<T> #15482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 9 files 9 suites 1d 16h 50m 24s ⏱️ Results for commit 83438bc. ♻️ This comment has been updated with latest results. |
enirolf
approved these changes
May 11, 2024
|
|
||
| /// Given a pointer to an std::optional<T> in from, extract a pointer to the value T* and a pointer | ||
| /// to the engagement boolean. Assumes that an std::optional<T> is stored as | ||
| /// `struct { T t; bool engagement; };` |
There was a problem hiding this comment.
Can there be cases where this is not true? Can/should we check for this?
There was a problem hiding this comment.
We rely on the unit tests to catch when this is not the case. I added some more testing on the object sizes and alignments.
Co-authored-by: Florine de Geus <git@fwdg.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.