New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove module aliases #4393
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4393 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 204 205 +1
Lines 7325 7326 +1
Branches 2081 2081
=======================================
+ Hits 7232 7233 +1
Misses 34 34
Partials 59 59
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the failing tests
Ah sorry, missed that this is a draft PR |
no worries. yeah, it's not quite there yet. the build currently works, if one kicks off Line 2 in 5f4d04f
it's part of the preliminary work to make I think it would make development and debugging, and therefor hopefully contributions, easier, without going through the rollup process. it would also be easier to run any performance related tools on top of the original code (typescript minus the stripped types) if one measures perf essentially against itself. |
1e6f5a9
to
4363162
Compare
33e54ba
to
abebdfe
Compare
eca6a6c
to
71d20c9
Compare
cbd94e6
to
f1538ce
Compare
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description