Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @rogden,
I started this before noticing #91 but luckily I had already decided to limit the upgrade to Vue 2.x so as to not mess with existing dependencies.
So this PR will give you Vite 馃敟, but not force any Vue 3 upgrade 馃憖.
And when you want to upgrade to Vue 3, it should only be a couple of changes (see below)
Status
I have the main build running great with Vite, which can check out and run right now.
However, I noticed that the CLI
export
script is not happy with the mix of ES6 and CJS, so that will need some tweaking; either upgrading that module to ES6 / imports, or downgrading thetailwind.config.js
file to CJS.I'm not hugely experienced with tailwind (hence #97) and whether there are user constraints that would require config to remain at CJS, perhaps you can advise? I'm sure there is a way for Vite to import a CJS file, so I'm happy to investigate.
Also, seeing as #91 was ultimately rejected, are you happy for this PR to continue?
Future upgrade to Vue 3
Change:
@vitejs/plugin-vue2
to@vitejs/plugin-vue
vue
version to^3.0.0