Make sure we use an adapter for our faraday connection #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding middleware to the faraday connection we need to be explicit about which adapter we'll use, otherwise no HTTP requests are actually made. Sadly, Faraday doesn't raise an exception if the adapter is missing and you end up debugging cryptic error messages raised from the middleware 馃惣 For more information see: lostisland/faraday#317
manmartinez
force-pushed
the
use-faraday-adapter
branch
from
4b31343
to
c405537
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
When adding middleware to the faraday connection we need to be explicit about which adapter we'll use, otherwise no HTTP requests are actually made.
Sadly, Faraday doesn't raise an exception if the adapter is missing and you end up debugging cryptic error messages raised from the middleware 馃惣
For more information see: lostisland/faraday#317