player: implement sync_retire_track() #110
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just posting this as a draft before it falls off my radar in case I get busy with other stuff. This is more just a PoC draft than anything, since we can't really extend the protocol like this without #108 being addressed first. Plus this would need a rebase if #107 lands so it uses |
This adds the ability to "retire" a track, which frees the track and its associated keys, sending RETIRE_TRACK to the Editor if connected so the Editor can also discard the track from its UI. The track id is not recycled to keep things simple for now. The impetus for this is demos having an interactive creative process that dynamically add tracks at different names as the composition evolves. With enough iteration, there's a tendency for a large amount of unused tracks to accumulate. This gives such interactively constructed demos a mechanism for discarding tracks from the Editor when they become unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to "retire" a track, which frees the track and its associated keys, sending RETIRE_TRACK to the Editor if connected so the Editor can also discard the track from its UI.
The track id is not recycled to keep things simple for now.
The impetus for this is demos having an interactive creative process that dynamically add tracks at different names as the composition evolves. With enough iteration, there's a tendency for a large amount of unused tracks to accumulate.
This gives such interactively constructed demos a mechanism for discarding tracks from the Editor when they become unused.