Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #220: Fix large scroll steps when content is long #221

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MihaiBalint
Copy link

If the content-to-viewport ratio is very high then the bar should be tiny and the scroll step should be normal. However the delta formula does not consider the fact that the bar height is restricted to a minimum height (for usability) and incorrectly increases the scroll step length with the content size.

With large content (in my case it was 150 000px) and default options, the large step size makes scrolling very coarse to the point of unusable.

@MihaiBalint
Copy link
Author

I believe this also fixes #233 and possibly also #211

@kasperoo
Copy link

2 thumbs up for this, you have fixed the scrollbar updating the position when using the scrollBy method for me. (essentialy #233)

@r3verser
Copy link

@MihaiBalint nice fix bro!

@MacMaru
Copy link

MacMaru commented Dec 15, 2016

I ran into large differences between browsers, has anyone looked at http://stackoverflow.com/questions/5527601/normalizing-mousewheel-speed-across-browsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants