Added support for keybd events #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for this, makes scrolling much more accessible. |
|
@aharikrishnan 👍 |
|
Perfect, why this change was not merged? |
|
This would be very useful :). Sadly, the changes are not currently working for me. Just tried reapplying the changes over a new fork of the current repository and the up/down keys were not working as they should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes accessibility issue
#191Added two new options
tabIndexandpageScrollThresholdtabIndex: Adds tabindex attribute with the value provided default is 0, tabIndex are necessary for keyboard navigationpageScrollThreshold: On PageUp / PageDown, this option allows to specify number of pixels to scroll back to maintain continuity instead of doing full page scroll.