Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing gym_ignition even if Ignition Gazebo is not installed in the system #348

Open
diegoferigo opened this issue May 12, 2021 · 1 comment

Comments

@diegoferigo
Copy link
Member

This is more or less similar to what we were doing long time ago with pybullet (#110, #149).

In few words, after #346 the pure-Python gym-ignition package will depend on scenario. When gym-ignition gets installed in a system (currently only Ubuntu is supported), the wheel of scenario will be installed first. Since the wheel of scenario is not self-contained (i.e. it needs to find in the system the Ignition libraries), if Ignition is not installed, the import of scenario.bindings.gazebo will fail. Therefore, in such systems, gym-ignition cannot be imported.

This seems quite logical, however there are use cases in which resources that are currently included in gym-ignition could be useful even if Ignition is not available in the system. For instance, all the high-level iDynTree classes.

Importing lazily all the scenario.bindings.core is quite easy to do, and I think we should try to support this use case.

cc @GiulioRomualdi @paolo-viceconte @traversaro

@diegoferigo diegoferigo changed the title Allow import gym_ignition even if Ignition Gazebo is not installed in the system Allow importing gym_ignition even if Ignition Gazebo is not installed in the system May 12, 2021
@diegoferigo diegoferigo added the good first issue Good for newcomers label May 12, 2021
@diegoferigo
Copy link
Member Author

This does not play that well with the current status of type hinting. Putting it in the backlog for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant