Feature/pipelines #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces two new classes, SamPromptCreator and SamResponseProcessor, in sam_segmentation.py.
Deleted the primitives.py and postprocessing.text.py files along with their corresponding tests as their functionalities have been refactored. parse_mark_id method from the deleted files have been moved to sam_segmentation.py which is a simplified version of the extract_marks_in_brackets method and is more suitable for the task at hand. extract_relevant_masks has been replaced by a process method in SamResponseProcessor which extracts the relevant mark ids from the text and uses them to index the detections object. The mark generating classes have been moved to the wrappers directory as they are effectively serving as wrappers around existing models. Made these changes to make the classes more modular, easy to understand and use. They can be extended in the future to include more models other than SAM. Also, created two new abstract base classes BasePromptCreator and BaseResponseProcessor in base.py file under pipelines directory. These two classes would be used to ensure a consistent structure across different pipelines. In maestro/__init__.py, SegmentAnythingMarkGenerator was renamed to SegmentAnything to adhere to the new structure. Bumped the version of Maestro to 0.2.0rc1 from 0.1.1rc1 reflecting the amount of changes made. Finally, updated README.md to reflect the changes made to the API but the new API usage example still needs to be added.
Deleted 'get_started.md', 'lmms.md', 'markers.md', 'visualizers.md', and 'visualizers.py' due to changes in the project structure and features. Extracted 'extract_mark_ids' method and placed it in 'sam_segmentation.py' for better coherence. Modified 'maestro/__init__.py' and 'mkdocs.yaml' to reflect current file structure and update some definitions. Furthermore, added new features to 'sam_segmentation.py'. These changes improve code modularity and update the project with new features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO
Type of change
Please delete options that are not relevant.
Docs