Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add robocorp-controlroom for operating with the new Control Room API #88

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

Add robocorp-controlroom for operating with the new Control Room API #88

wants to merge 23 commits into from

Conversation

cmin764
Copy link
Member

@cmin764 cmin764 commented Oct 30, 2023 •
edited

Blockers

  • Fixing the pydantic types: HasMore, Next. ✅

ToDo

  • Remove the research when not needed anymore.
  • Remove the tests directory. (as it's empty and not needed)
  • Generate code in a subdir called _client. (so we isolate it from the rest of the public-interfaced libs)
  • Auto-pass workspace_id by patching the generated API class.
  • Fix README on reference: [API Key with permissions](../README.md#API Key with permissions)
  • Handle request errors & retry like happens in the other libs.
  • Ensure truststore injection and TLS behaviour still works.

@cmin764 cmin764 added the Improvement Improving an existing feature label Oct 30, 2023
@cmin764 cmin764 requested review from fabioz and osrjv October 30, 2023 11:46
@cmin764 cmin764 self-assigned this Oct 30, 2023
@cmin764 cmin764 linked an issue Dec 12, 2023 that may be closed by this pull request
Add robocorp-controlroom package and library #106
Open
@cmin764 cmin764 changed the title Add robocorp-workspace for operating with the new Control Room API Add robocorp-controlroom for operating with the new Control Room API Dec 12, 2023
@cmin764 cmin764 removed the request for review from osrjv December 12, 2023 12:21
@cmin764 cmin764 added high priority Feature Adds a completely new feature and removed Improvement Improving an existing feature high priority labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabioz fabioz Awaiting requested review from fabioz

Assignees

@cmin764 cmin764

Labels
Feature Adds a completely new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add robocorp-controlroom package and library
1 participant
@cmin764