Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code line numbering #386

Merged
merged 12 commits into from Jun 1, 2022
Merged

Add code line numbering #386

merged 12 commits into from Jun 1, 2022

Conversation

robdy
Copy link
Owner

@robdy robdy commented Dec 17, 2021

  • During the initial render, wrapping is not set to 'ON' even if set in the localStorage

Issue: it's not easy to enter line numbering. MDX doesn't render lines in separate <code> elements.

Possible solution: check for \n\n elements.

Checked: embedeed Prims line breaks don't work well with word wrapping

gatsbyjs/gatsby#309 (comment)

Fixes #385

@netlify
Copy link

netlify bot commented Dec 17, 2021

Deploy Preview for robdy-io ready!

Name Link
🔨 Latest commit 2846276
🔍 Latest deploy log https://app.netlify.com/sites/robdy-io/deploys/6297413753d0fd000920d6f4
😎 Deploy Preview https://deploy-preview-386--robdy-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@robdy robdy changed the title Add custom pre block Add code line numbering Dec 17, 2021
@robdy robdy marked this pull request as ready for review June 1, 2022 10:36
@robdy robdy mentioned this pull request Jun 1, 2022
@robdy robdy merged commit 2e0bb92 into src Jun 1, 2022
@robdy robdy deleted the 385-linenumbers branch June 1, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add line numbers to code
1 participant