fixed names order according to data/testdata.json names order #168
Conversation
|
The names in the test are in alphabetical order; the code that makes the test pass should put the names in alphabetical order as well. If you want to amend this PR to restore the existing test, but add a comment explaining the alphabetization requirement, we could land that PR. |
|
Where is the best to place a comment? |
|
I'd personally think in the test, but where ever you think it would be most useful is fine by me. |
|
I think that it will be more useful to see this caution when somebody already implements this function. So I've placed in functions implementations. |
| @@ -33,7 +33,7 @@ describe('async behavior', function() { | |||
|
|
|||
| asyncAnswers.manipulateRemoteData(url).then(function(result) { | |||
| expect(result).to.have.length(5); | |||
| expect(result.join(' ')).to.eql('Adam Alex Matt Paul Rebecca'); | |||
There was a problem hiding this comment.
Now that you've added the note in the code, this reordering isn't necessary.
Can't understand why names in test are listed in another order.