Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for s390x architecture #68

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

jschintag
Copy link
Contributor

Add s390x to build targets.

I would like to add s390x support for this project, as it is a required dependency to enable kubevirt for s390x.

There is not really anything else needed to be done for this. I did not find any tests or CI that would need changes.

Please let me know if there are any other required changes that i missed or if there are any question.

Add s390x to build targets.

Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
@jschintag
Copy link
Contributor Author

@rmohr Is this a PR that would be acceptable to bazeldnf? Is there any additional work/commitment needed from my side to enable s390x arch for this project?

Copy link
Owner

@rmohr rmohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rmohr rmohr merged commit 3a8771e into rmohr:main Jan 25, 2024
1 check passed
@rmohr
Copy link
Owner

rmohr commented Jan 25, 2024

https://github.com/rmohr/bazeldnf/releases/tag/v0.5.9-rc2 seems to have the artifact published as intended :)

@jschintag jschintag deleted the enable-s390x branch January 26, 2024 06:58
@jschintag
Copy link
Contributor Author

Thank you, i will pick it up right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants