Fix tar2files bazel integration #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The names that are passed to bazeldnf need to include the directory part too, otherwise having two files with the same name in different paths triggers a failure: + bazel run --config x86_64 //rpm:sandbox_s390x ... Error in _tar2files: generated file 'cc-toolchain_s390x/errno.h' in rule 'cc-toolchain_s390x/usr/include/asm' conflicts with existing generated file from rule 'cc-toolchain_s390x/usr/include' Signed-off-by: Andrea Bolognani <abologna@redhat.com>
19 tasks
|
Thanks Andrea! |
|
Excellent, thanks! |
andreabolognani
added a commit
to andreabolognani/kubevirt
that referenced
this pull request
Jan 29, 2024
This version contains a change needed for the upcoming s390x support, namely rmohr/bazeldnf#66 Note that, as a consequence of that change, we need to update the definition of libvirt-libs, as libvirt header files are now inside the /usr/include/libvirt/ directory of the generated tar file. Signed-off-by: Andrea Bolognani <abologna@redhat.com>
andreabolognani
added a commit
to andreabolognani/kubevirt
that referenced
this pull request
Jan 30, 2024
This version contains a change needed for the upcoming s390x support, namely rmohr/bazeldnf#66 Note that, as a consequence of that change, we need to update the definition of libvirt-libs, as libvirt header files are now inside the /usr/include/libvirt/ directory of the generated tar file. Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names that are passed to bazeldnf need to include the directory part too, otherwise having two files with the same name in different paths triggers a failure: