Support file:// scheme for repo URLs #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a repo.yaml file, instead of just the http:// or https:// scheme,
the user might want to specify a local path for an repo, e.g.
repositories:
- arch: x86_64
baseurl: file:///RPMS
name: local
And then use that with fetch, e.g.
% bazeldnf fetch
INFO[0000] Resolving repomd.xml from file:///RPMS/repodata/repomd.xml
INFO[0000] Loading primary file from file:///RPMS/repodata/<HASH>-primary.xml.gz
To address this, update the Getter implementation to parse the URL
using net/url Parse, and the call a handler that opens a local file
and returns a wrapper http.Response when the scheme is "file".
|
@rmohr mind a quick look here? |
rmohr
approved these changes
Oct 6, 2023
wwade
pushed a commit
to wwade/bazeldnf
that referenced
this pull request
Oct 6, 2023
Pull request rmohr#63 added support for the `file://` scheme for `fetch`. This change adds the suggested test case to ensure that both the baseline `http://` support and the newly-added `file://` support are working as expected.
Done, added in #64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a repo.yaml file, instead of just the http:// or https:// scheme, the user might want to specify a local path for an repo, e.g.
And then use that with fetch, e.g.
To address this, update the Getter implementation to parse the URL using net/url Parse, and the call a handler that opens a local file and returns a wrapper http.Response when the scheme is "file".