-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor bug fixes #38
base: master
Are you sure you want to change the base?
Minor bug fixes #38
Conversation
Line 108: Show results if picked option is blank.
Show results if a blank option is selected
allowMismatch bug fix
This appears to break the general |
Apologies, forgot to copy over one more change from my own copy. Also when retesting I noticed there's no setValue call |
Ok, came to realise the method I used may not be suitable for all cases (I was simply setting the value to blank and not triggering the change event if
Both of these can be fixed by appending a blank option on init, but the following issue still exists:
Proposed change
Unfortunately not the simplest of solutions, but it's the only way I can think of to have it working as expected in all cases. I thought I'd get your opinion before going ahead and making these changes. Let me know what you think. |
Line 108:
Show results if picked option is blank.
If a blank option was present, results would previously not show on focus.
Line 315:
Change
setValue.val("");
tosetValue("");
. This will now set originalselect
's value to blank as intended.Previously this would have no
effect and instead keep previously selected values.
Fixes issues #13 and #37.