Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find_topics function #49

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add find_topics function #49

wants to merge 9 commits into from

Conversation

ledell
Copy link
Member

@ledell ledell commented Jun 3, 2019

Issue: #44

Here's how it works:

> topics <- find_topics(text = "R-Ladies", api_key = api_key)
Downloading 2 record(s)...
> topics
# A tibble: 2 x 7
       id name          urlkey         member_count description                       group_count resource
    <int> <chr>         <chr>                 <int> <chr>                                   <int> <list>  
1 1513883 R-Ladies      r-ladies              40839 Find out what's happening in R-L…         141 <list […
2 1387242 WHERE R U HE… where-r-u-hea…            0 Find out what's happening in WHE…           0 <list […

Once you see the topic id, you can use it find all groups of that specific topic:

> groups <- find_groups(topic_id = 1513883, api_key = api_key)
Downloading 141 record(s)...

@ledell ledell requested a review from LucyMcGowan June 3, 2019 17:34
@ledell
Copy link
Member Author

ledell commented Jun 11, 2019

Hey @LucyMcGowan do you have any comments on this PR?

@ledell
Copy link
Member Author

ledell commented Jun 12, 2019

@hfrick Do you mind taking a quick review of this?

@hfrick
Copy link
Member

hfrick commented Jun 14, 2019

sure! (it'll be next week though)

@drmowinckels
Copy link
Member

drmowinckels commented Feb 9, 2021

I've not added test etc for the new functions in this PR, but have gone through and resolved conflicts with current master @maelle and @ledell

But forgot to run checks. Will get the new funcs adapted to the new api.

@drmowinckels
Copy link
Member

I didnt fix tests, sorry, just have not have time to sit down with vcr and understand how it works. But I have made sure the PR no longer has conflicts with master, and that is generally fits with the updates lately. I also collected the two find-functions into a single file with common rd.

@benubah
Copy link
Collaborator

benubah commented Aug 4, 2022

With the new GraphQL API, this PR should be obselete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants