New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing `get_event_attendees()` test #146

Open

thisisnic wants to merge 2 commits into rladies:master from thisisnic:get_groups_test

thisisnic commented May 7, 2024

The test for get_event_attendees() was failing because there was an extra field (timezone) returned, which wasn't expected.

The comparison was also issuing a warning.

In this PR, I:

updated the query so it doesn't return the timezone field - I'm guessing we don't want this field, but I could refactor the tests to expect this field if we do
update the test to use expect_setequal() so we don't get an additional warning if the test fails

thisisnic added 2 commits

May 7, 2024 11:34


          Remove timezone field from the eventAttendee query

5b319bc


          Update test so don't get warning as well as error on mismatch

dfd1b00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment