Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

Expose raw ports using docker2aci style port syntax #3967

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dmwilcox
Copy link

This change was created to allow ports to be exposed without being in the image manifest. It uses the same syntax as generated manifests from docker2aci (e.g. '80-tcp', etc). Motivation is for running Envoy as a sidecar -- which discovers the ports it listens on at run-time rather than at image build time.

Happy to add tests + docs or change strategy if desired. I wanted to use OCI syntax as suggested in #2113 but this requires a change to ACName. The advantage of that approach is not overloading the docker syntax -- wherein people may get confused that a docker image port has changed and they no longer get an error but instead have exposed a raw port. I'm happy to pursue that route as well.

I'm not opposed to other strategies such as #3407 but am concerned it appeared to have died on the vine. Rkt's native pod support is an excellent feature for doing sidecars right at the runtime layer and I really want to see service mesh sidecars like Envoy compatible with Rkt.

@SuperQ
Copy link

SuperQ commented Jan 11, 2019

/cc @squeed

@dmwilcox
Copy link
Author

Hi @lucab I see you've looked at a few PRs trying to add raw ports to rkt before -- do you have some time to look at this with me? Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants