This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
rkt: add fixes to build with gccgo #3963
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport https://golang.org/cl/34379, along with other changes.
|
@ianlancetaylor I don't think you should modify the files in the vendor directory, you should go upstream and modify them |
|
The changes are already upstream. But when I tried re-vendoring all of upstream it caused this package to fail to build with older versions of Go. And note that as far as I can tell the upstream packages were not fully vendored in the first place. |
|
Okay, sorry |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces pull request #3962, which did a full update of github.com/klauspost/compress/flate and golang.org/x/sys/unix, which failed to build with older versions of Go. Instead just cherrypick the changes required for gccgo support.
Updates golang/go#28670