This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
tests: ensure / is mounted shared on semaphore; fix kvm failure #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the contents of the error were lost in that path.
See rkt#3940 for why / needs to be shared. Specifically, the test TestAppSandboxAddStartRemove failed on sempahore without this change. The test did work in the past, but that's because sempahore used to run an old version of docker which remounted / as shared for us.
Comparing the network namespace observed inside a VM with one observed outside of it makes little sense; in fact, it's perfectly reasonable for those values to be the same even if in reality they're distinct network namespaces (due to being different kernels). In practice, the id '4026531957' for pid 1 on both the host and in the kernel appears fairly consistently. This resulted in `TestNetDefaultNetNS` failing on semaphore. I have not dug into this deeply enough to know why this issue didn't crop up before. Presumably some kernel change on the semaphore host resulted in it generated netns ids in a more similar way to the coreos kernel included in stage1-kvm. Regardless, disabling the test seems to be the correct solution to this issue.
euank
changed the title
|
I added a new commit which fixes the kvm failure as well. The commit's message includes the details as to why it was failing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
coreosflavor failure semaphore is having. I haven't investigated thekvmfailure, so I have no clue if this might fix it too.See #3940 for the more general issue, this is just to get master back to passing without truly addressing the root issue.
I also included some minor changes which I made while investigating this since they're quite trivial.