docs: include keyserver in gpg instructions #3928
Conversation
taqtiqa-mark
changed the title
There was a problem hiding this comment.
Thank you for the doc improvement.
I have a comment below about what additional disclaimers we may want here which I would like to get some second opinions on.
I think the commit subject/message are also unclear right now.
The subject should include the subsystem and explain what it fixes, not reference an issue (e.g. docs: include keyserver in gpg instructions).
The body also mentions corporate proxies, which isn't relevant here I think since the issue this fixes will be encountered when keyservers are not configured, regardless of the proxy configuration.
If there is a corporate proxy in effect, it's possible additional steps would be required, which I think are out of scope of rkt's docs.
Documentation/distributions.md
Outdated
| @@ -146,7 +146,7 @@ upgrade manually. | |||
|
|
|||
| ### rpm-based | |||
| ``` | |||
| gpg --recv-key 18AD5014C99EF7E3BA5F6CE950BDD3E0FC8A365E | |||
| gpg --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-key 18AD5014C99EF7E3BA5F6CE950BDD3E0FC8A365E | |||
There was a problem hiding this comment.
I agree with @squeed's comment that "we at the rkt project can't decide this".
I have no problem with us recommending a reasonable option, but I'd rather we make it clear that you should prefer any that your distro or you have already picked.
Perhaps having a comment to that effect would be enough, e.g.
# Note: the example keyserver argument should be omitted if you already have a keyserver configured or you do not trust the SKS Keyservers
| ``` | ||
| gpg --recv-key 18AD5014C99EF7E3BA5F6CE950BDD3E0FC8A365E | ||
| gpg --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-key 18AD5014C99EF7E3BA5F6CE950BDD3E0FC8A365E |
There was a problem hiding this comment.
Isn't hkp://pool.sks-keyservers.net enough? That seems to be recommended URL from https://sks-keyservers.net/ homepage.
There was a problem hiding this comment.
My experience is accessing port 80 causes less issues for drive-by users. You can really pick the pool that scratches your itch:
https://sks-keyservers.net/overview-of-pools.php
|
Apologies that this seems to have fallen off of people's radar. This LGTM once they're squashed. |
doc: include keyserver in gpg instructions. Closes issue rkt#3919.
docs: include keyserver in gpg instructions. Closes issue #3919.