This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
iottymux: add support for json formatted logs akin to docker #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I'll try to have a look this week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR piggybacks on the
k8s-plainformat introduced in #3798 which allowed for CRI compliant output out of the iottymux module. It introduces a json format option, mimicking docker log's default style.Me and my partner @jyouchan were playing around with the rkt repository for a final project in our upper division virtualization class. We ended up implementing docker style json logging as a proof of concept, and thought that it might be useful. Feel free to reject the PR if it doesn't align with rkt's goals!