Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos in constants.ts, Form.tsx #4185

Merged
merged 3 commits into from May 17, 2024
Merged

fix typos in constants.ts, Form.tsx #4185

merged 3 commits into from May 17, 2024

Conversation

HanJaeJoon
Copy link
Contributor

Reasons for making this change

fix typos

  • RJSF_ADDITONAL_PROPERTIES_FLAG => RJSF_ADDITIONAL_PROPERTIES_FLAG
  • acceptcharset => acceptCharset

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

heath-freenome
heath-freenome reviewed May 10, 2024
View reviewed changes
packages/utils/src/constants.ts Show resolved Hide resolved
packages/core/src/components/Form.tsx Show resolved Hide resolved
packages/core/src/components/Form.tsx Show resolved Hide resolved
packages/core/src/components/Form.tsx Outdated Show resolved Hide resolved
@HanJaeJoon
Copy link
Contributor Author

@heath-freenome
I applied all your suggestions. I didn't thought of backwards compatibility, thanks!

@HanJaeJoon HanJaeJoon force-pushed the fix-typo branch 2 times, most recently from c2a709d to c90470d Compare May 14, 2024 00:44
@HanJaeJoon @heath-freenome
keep the constants to for backwards compatibility
d39ec96 
Co-authored-by: Heath C <51679588+heath-freenome@users.noreply.github.com>
@heath-freenome heath-freenome merged commit 38f7d32 into rjsf-team:main May 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heath-freenome heath-freenome heath-freenome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HanJaeJoon @heath-freenome