feat(NFT): add nft_id to search bar #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnxie999
requested review from
ckniffen
and removed request for
ckniffen
mvadari
reviewed
Sep 12, 2022
ckniffen
reviewed
Sep 12, 2022
ckniffen
reviewed
Sep 12, 2022
mvadari
reviewed
Sep 13, 2022
src/containers/Header/Search.jsx
Outdated
| await getTransaction(rippledContext, id) | ||
| return 'transactions' | ||
| } catch (e) { | ||
| return 'token' |
There was a problem hiding this comment.
The key for NFTs should really be something like nft or nftoken, instead of using token. It's a different page type.
There was a problem hiding this comment.
do you mean we should change the url to something like /nft/:id?
There was a problem hiding this comment.
also i don't like the name of this function with relation to its return type. this name should return a boolean and be named something like isTransaction. Given what this does, it should be named something like determineTypeOfHash
There was a problem hiding this comment.
@ledhed2222 soon we will have AMM Instances added to the list of 64 character hexs that we have to determine the type of.
ckniffen
approved these changes
Oct 5, 2022
ledhed2222
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
nft_infoto check if its NFT (sincetransactionsandnft_idshare the same 64-digit hex syntax)asyncwithinSearchcomponent to support for async API calltoken/:idtonft/:idContext of Change
Type of Change
TypeScript/Hooks Update
Before / After
After clicking Enter
Test Plan