feat: make targetMembers case sensitive
#1077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
- Coverage 91.18% 91.18% -0.01%
==========================================
Files 220 220
Lines 7203 7201 -2
Branches 915 915
==========================================
- Hits 6568 6566 -2
Misses 418 418
Partials 217 217 ☔ View full report in Codecov by Sentry. |
TimothyMakkison
force-pushed
the
name_backing_field
branch
from
cb64d59
to
1854967
Compare
latonz
requested changes
Jan 23, 2024
| return BuilderContext | ||
| .SymbolAccessor.GetAllAccessibleMappableMembers(Mapping.TargetType) | ||
| .ToDictionary(x => x.Name, StringComparer.OrdinalIgnoreCase); | ||
| return BuilderContext.SymbolAccessor.GetAllAccessibleMappableMembers(Mapping.TargetType).ToDictionary(x => x.Name); |
There was a problem hiding this comment.
Doesn't
src\Riok.Mapperly\Descriptors\MappingBodyBuilders\BuilderContext\NewInstanceBuilderContext.cs:10 and src\Riok.Mapperly\Descriptors\MappingBodyBuilders\BuilderContext\NewInstanceContainerBuilderContext.cs:17 have the same problems for configurations?
| @@ -235,7 +235,7 @@ private static void BuildConstructorMapping(INewInstanceBuilderContext<IMapping> | |||
| continue; | |||
| } | |||
|
|
|||
| ctx.TargetMembers.RemoveRange(mappedTargetMemberNames); | |||
| ctx.TargetMembers.RemoveRange(ctx.TargetMembers.Keys.Intersect(mappedTargetMemberNames, StringComparer.OrdinalIgnoreCase)); | |||
There was a problem hiding this comment.
Not sure if we should adjust this to use a similar approach to RootTargetNameCasingMapping, wdyt?
- Create a case mapping dictionary
- Use that dictionary to resolve correct casing in
AddConstructorParameterMappingand remove fromTargetMembersdictionary accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having two members with case insensitive similar names would cause mapperly to fail.
value&ValueTargetMembercase sensitiveFixes #1076
Checklist