Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging Layoutlexer #646

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

ishmum123
Copy link

No description provided.

@ishmum123
Copy link
Author

@rikvdkleij I got the tests running (by replacing with the actual), the simplelayout and letin tests are still failing

@ishmum123
Copy link
Author

@rikvdkleij please suggest a change I would try do as much as I can

@rikvdkleij
Copy link
Owner

@ishmum123 Sorry, I also don't know how to continue exactly. We have to define a PSI tree which will parse all GHC code. I need some time to investigate this.

@ishmum123
Copy link
Author

@ishmum123
Copy link
Author

ishmum123 commented Mar 9, 2021

Let me know if you want to pair program

@ishmum123
Copy link
Author

@rikvdkleij does this push give you any ideas about the solution?

@ishmum123
Copy link
Author

@rikvdkleij I could get the layout tests to pass after modifying the where_clause. For some reason cannot parse real files that I have tested with. Would you please take a look?

@rikvdkleij
Copy link
Owner

@ishmum123 do you mean that you can’t parse real files when the plugin is used?

Great that you still working on this issue!

@ishmum123
Copy link
Author

@rikvdkleij yes getting some problems on real files. Can you please check where it might have gone wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants