[Mobile] - Android crashes and card scrolling #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook/react-native#17530 and crash 2: disable hermes for a better crash report
version #
drewjhart
commented
Mar 10, 2023
| @@ -138,7 +138,7 @@ android { | |||
| applicationId "com.rightonnew" | |||
| minSdkVersion rootProject.ext.minSdkVersion | |||
| targetSdkVersion rootProject.ext.targetSdkVersion | |||
| versionCode 6 | |||
| versionCode 8 | |||
There was a problem hiding this comment.
This is the correct build number (and version 8 has been built through Android Studio). There was some last minute builds trying to get better crash reporting through bugsnap to understand the crash more but ultimately it was simpler to just swap out the unneeded and problematic TextInput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to our demo, we noticed some crashes and scrolling issues on the Android side of the
mobileapp.There is a crash associated with
TextInputsin aFlatLiastwhich impactsPhaseOneGamePlayandPhaseTwoGamePlay. More information can be found here:facebook/react-native#17530
This involves the styling of underline properties in a
TextInputproducingNullPointerExceptionand hasn't been clearly addressed in the above issue to RN. I implemented the suggested solution (specifying the styling in thexml) and still ran into the issue. We don't actually needTextInputhere though, so I've substituted them forTextand that resolved the issue.There were also some issues with scrolling not working on Android. This PR also resolves that.