Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in vqe_run when disp = True #209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Kaustuvi
Copy link

@Kaustuvi Kaustuvi commented Jun 4, 2019

This commit fixes the bug when disp = True in vqe_run. The corresponding issue is #205

@notmgsk
Copy link

notmgsk commented Jul 10, 2019

Hi, @Kaustuvi. Apologies for the delay.

I suggest we fix the documentation of vqe_run rather than change the implementation details. Being able to pass a custom printer function seems more useful than strictly using python's print.

Copy link

@notmgsk notmgsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above.

@Kaustuvi
Copy link
Author

Hi @notmgsk, thanks for your feedback! It makes sense to rather change the documentation than restrict the print function. Thanks for the suggestion. I'll make these changes and update the PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants